Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grootle verification hardening #1387

Merged

Conversation

AaronFeickert
Copy link
Contributor

PR intention

Hardens Grootle proof verification in Spark transactions.

Code changes brief

Offset commitments and challenge powers in Grootle proofs ought not to be zero. This PR ensures these things don't happen.

Copy link
Contributor

@psolstice psolstice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoke test before releasing

Copy link
Contributor

@levonpetrosyan93 levonpetrosyan93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did reindex on testnet, passed

@levonpetrosyan93 levonpetrosyan93 merged commit 34bd5ff into firoorg:master Jan 15, 2024
5 checks passed
@AaronFeickert AaronFeickert deleted the reject-spark-zero-keys branch January 15, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants